Skip to content

Delete all associated todos without N+1

Patrick Bajao requested to merge 325689-todos-delete-all into master

What does this MR do?

The Issuable::DestroyService gets called for DELETE /api/projects/:id/merge_requests/:merge_request_iid endpoint.

When deleting an issuable (Issue or MergeRequest), the associated Todo records need to be deleted as well.

Before this change, it was calling Todo#destroy on each associated todo that results to N+1 issues.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325689 (closed)

Edited by Patrick Bajao

Merge request reports