Skip to content

Resolve "API endpoint PUT /projects/:id/merge_requests/:merge_request_iid/approvers executes more than 100 SQL queries"

What does this MR do?

This endpoint was scheduled to be removed in %12.0 but never was. It has shown as "deprecated" in the docs for several years now - but now the endpoint has a few bugs and is causing database performance to suffer. There is no formal issue to actually remove the endpoint, which may be why it was missed.

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #8883 (closed)

Edited by Michelle Gill

Merge request reports