Resolve "API endpoint PUT /projects/:id/merge_requests/:merge_request_iid/approvers executes more than 100 SQL queries"
requested to merge 8883-api-endpoint-put-projects-id-merge_requests-merge_request_iid-approvers-executes-more-than-100 into master
What does this MR do?
This endpoint was scheduled to be removed in %12.0 but never was. It has shown as "deprecated" in the docs for several years now - but now the endpoint has a few bugs and is causing database performance to suffer. There is no formal issue to actually remove the endpoint, which may be why it was missed.
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #8883 (closed)
Edited by Michelle Gill