Skip to content

Draft: Fix N+1 problems loading MRs in API::V3::Github [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Luke Duncalfe requested to merge 33741-api_v3_merge_request_optimization into master

What does this MR do?

This MR applies eager loading to API::V3::Github endpoints to avoid N+1 issues when serializing merge requests.

The N+1 issues happen when a collection of MergeRequests are serialised as API::Github::Entities::PullRequest entities. The entity serializes these associations:

Related issues:

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #33741 (closed)

Edited by Luke Duncalfe

Merge request reports