Skip to content

Ensure search param is kept in scrolled commit

Samantha Ming requested to merge 24551-keep-search-param-in-commit-scroll into master

What does this MR do?

There is an issue when search commit terms are not kept when scrolling down for more commits. In this MR we fix this so the search term is kept.

Bug (no search when scrolled ) Fixed (has search when scrolled )
24551-Bug 24551-Fixed

Note: If the user hits enter on the search term, the bug does not happen. It only exists when the user types the search and does not click the enter on their keyboard.

Testing Case

  1. Go to Repository > Commits
  2. Put in a search term and wait (do not press enter)
  3. Scroll down to load more results
  • the search term is included in the request

image

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #24551 (closed)

Edited by Samantha Ming

Merge request reports