Improve line rendering speed [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Speeds up rendering of diffs by inlining the template instead of using partial rendering. Even with the collection syntax for partials there is an inherent overhead, and we render a lot of lines, so this has an overall benefit. It also simplifies the line rendering for the primary use-case by splitting the email and plain variations off into their own file.
The exact performance benefits are hard to measure locally - I'll be measuring them using the feature flag. I would expect around a 10% improvement based on past experience.
After this is merged we may be able to go further and cache the rendered diffs.
Related #322559 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team