Add bulk edit to issues list page refactor
What does this MR do?
This MR adds bulk edit to the issues list page refactor from Haml to Vue, which is under the feature flag vue_issues_list defaulted to off.
The bulk edit sidebar is currently in Haml. It contains lots of dropdowns for selecting assignees and labels etc and refactoring this to Vue will take a lot of effort (which we currently don't have time for), so for now we will connect it with the Vue issues list with an event hub system which is already in place.
The .selected-issuable:checked selector was also changed to .issuable-list input[type="checkbox"]:checked so we can target the IssuableItem checkbox, which uses GlFormCheckbox that doesn't allow you to put the .selected-issuable class on its input. This change was tested for bulk edit on the project issues, project MRs, group issues, group MRs, and group epics pages with no problems.
List of issues list page refactor steps:
- Add missing UI elements to issue list card — Done in !55699 (merged)
- Add pagination — Done in !55699 (merged)
- Add sorting — Done in !56754 (merged)
- Add bulk edit — This MR!
- Add searching
- Add filtering
- Add missing filtered-search tokens
- Add empty state
- Add working Open/Closed/All tabs
Issue: #322755 (closed)
Screenshots (strongly suggested)
Screen_Recording_2021-03-23_at_11.52.10_am
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322755 (closed)