Skip to content

Fix applying keyset pagination attributes

Adam Hegyi requested to merge 325323-fix-attribute-name into master

What does this MR do?

Fixing a simple Symbol vs String problem when looking up values in a hash. The bug is not user facing (developer facing), it was discovered during development when the new keyset pagination library was first used.

Fix: make sure that we return and process hashes with indifferent access.

Related issue: #325323 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325323 (closed)

Edited by Adam Hegyi

Merge request reports