Skip to content

Draft: Remove N+1 query from register_job_service

Saikat Sarkar requested to merge remove_n+1 into master

What does this MR do?

This MR is related to this issue. This change removes the N+1 query problem for register_job_service. I want to mention that this MR is also related to #324369 (comment 534901267).

According to @allison.browne's analysis, ci_register_job_service_one_by_one was enabled on 11-March. After that, we see a huge volume of SQL calls. This MR tries to addresses the N+1 issue for ci_register_job_service_one_by_one.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Saikat Sarkar

Merge request reports