Skip to content

Disable Remove Group Button for Group with Subscription

Jason Goodman requested to merge prevent-delete-groups-with-subscription into master

What does this MR do?

Prevent deletion of groups with a paid gitlab.com subscription.

This prevents data integrity issues with CustomersDot that occur when a group is deleted while linked with a subscription. More details are in the issue.

Issue: customers-gitlab-com#1879 (closed)

Screenshots

A Premium subscription group with delayed deletes enabled cannot be deleted

Screen_Shot_2021-03-22_at_4.58.15_PM

A Bronze subscription group cannot be deleted

Screen_Shot_2021-03-22_at_5.08.50_PM

A subgroup of a Premium subscription group can be deleted

Screen_Shot_2021-03-22_at_5.46.37_PM

A subgroup of a Bronze subscription can be deleted

Screen_Shot_2021-03-22_at_5.09.34_PM

The link in the info text block links to the documentation

Screen_Shot_2021-03-22_at_5.48.23_PM

If the user somehow bypasses the button to force a delete, the backend prevents this:

If the user used the Chrome dev tools to enable the button, for instance.

Screen_Shot_2021-03-22_at_6.48.40_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports