Skip to content

Move Pipeline Editor repo link outside of feature flag conditional

What does this MR do?

Move Pipeline Editor link outside of the :consolidated_edit_button flag to allow editor team to iterate on that new feature without consulting Pipeline authoring team if they need it on or off. If the result of their experiment is successful, we would add the link inside the consolidated button.

Screenshots (strongly suggested)

With Flag off

Before After
Screen_Shot_2021-03-22_at_1.11.01_PM Screen_Shot_2021-03-22_at_1.11.01_PM
Screen_Shot_2021-03-22_at_1.11.17_PM Screen_Shot_2021-03-22_at_1.11.17_PM

With flag on

Before After
Screen_Shot_2021-03-22_at_1.15.34_PM Screen_Shot_2021-03-22_at_1.14.12_PM
Screen_Shot_2021-03-22_at_1.15.01_PM Screen_Shot_2021-03-22_at_1.15.01_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Frédéric Caplette

Merge request reports