Convert users of `FetchRemote` to use `RemoteParams` [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
When fetching remotes, we currently first create it and then fetch the created remote. This is an inefficient interface and awkward to use, as we have to assert that the remote exists each time we fetch. It's also vulnerable to races as we now depend on on-disk state of Gitaly.
Some time ago, Gitaly has introduces a new RemoteParams field to the
FetchRemote() RPC which enables callers to provide configuration of
the remote directly instead of passing the previously created remote.
This MR switches users of FetchRemote to use the new RemoteParams.
Part of gitaly#1773 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team