Skip to content

Disallow import url scheme to start with javascript

Ron Chan requested to merge rchan-gitlab/gitlab:manifest-unsafe-scheme into master

What does this MR do?

Close #284676 (closed)

This MR can prevent self XSS by validating the scheme of the URL does not start with javascript

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dominic Couture

Merge request reports