Optimise query for DeploymentsFinder by environment name
What does this MR do?
Optimises DeploymentsFinder query to not join environments table when searching by environment name
Rewrite to a much simpler query
- No need to search by name, unique index guarantees there can only be one environment by that name for a project
- Also no need to have where claus for deployments.project_id. An environment must belong to the same project_id anyway.
This only optimise for the project case which is which is used by GET /api/:version/projects/:id/deployments. We still use the original query for the group case.
Related issue: gitlab-com/gl-infra/production#4024 (closed)
Queries
- Before: https://console.postgres.ai/gitlab/gitlab-production-tunnel/sessions/2834/commands/8874
- After:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah