Skip to content

TodosDestroyer::EntityLeaveWorker generates expensive SQL queries

What does this MR do?

When trying to destroy group todos for a private group, we were inadvertently including public/internal groups, which caused performance issues.

We no longer include those groups.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #325133 (closed)

Edited by Adam Hegyi

Merge request reports