Include user namespace in list of fork targets
What does this MR do?
With the fork_project_form feature flag enabled, we don't pay any attention to the @own_namespace instance variable, instead expecting to get the full list of namespaces we can fork to in the JSON payload given by Projects::ForksController#new
Adding the namespace to that json payload allows us to render it without any special handling. It does mean that we now have a mixed array of Namespace and Group, so a few Group-specific things need to be supported by Namespace.
The alternative approach would be to start making use of @own_namespace, but that seems like more effort for a worse outcome.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have not included a changelog entry because this functionality is behind a feature flag
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #321387 (closed)