Skip to content

Include user namespace in list of fork targets

What does this MR do?

With the fork_project_form feature flag enabled, we don't pay any attention to the @own_namespace instance variable, instead expecting to get the full list of namespaces we can fork to in the JSON payload given by Projects::ForksController#new

Adding the namespace to that json payload allows us to render it without any special handling. It does mean that we now have a mixed array of Namespace and Group, so a few Group-specific things need to be supported by Namespace.

The alternative approach would be to start making use of @own_namespace, but that seems like more effort for a worse outcome.

Screenshots (strongly suggested)

Screenshot_from_2021-03-18_11-45-32

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321387 (closed)

Edited by Nick Thomas

Merge request reports