Skip to content

Update mock data and fix vacuous group id check in epic roadmap

euko requested to merge update-roadmap-graphql-mock-data into master

What does this MR do?

  • Updates the outdated roadmap mock data (fields and type mismatches, etc).
    • In addition to ensuring the fidelity of our tests, this eases us into testing with a mocked apollo client in the future.
  • Removes a small tech debt (removing unused/unnecessary utils from epic_utils.js)
  • Fixes a vacuous group id check in epic_item_details.vue

Screenshot

Before After
Screen_Shot_2021-03-22_at_10.51.46_AM Screen_Shot_2021-03-22_at_10.48.23_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by euko

Merge request reports