Skip to content

Remove unused GeoGitAccess method

Nick Nguyen requested to merge nhxnguyen-remove-unused-geo-code into master

What does this MR do?

Follow up from !56280 (comment 529883165)

Michael Kozono 🔶 @mkozono · 1 day ago Maintainer

Ah interesting. I think GeoGitAccess#push_to_read_only_message ("Please use the primary node URL instead") is dead code.

As long as https://gitlab.com/gitlab-org/gitlab/-/blob/b8b972849fce9aecda364d4f2749e2f6aa56c757/ee/app/controllers/ee/repositories/git_http_client_controller.rb and https://gitlab.com/gitlab-org/gitlab/-/blob/b8b972849fce9aecda364d4f2749e2f6aa56c757/ee/lib/gitlab/geo/git_ssh_proxy.rb correctly redirect/proxy Git push requests to the primary.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Aakriti Gupta

Merge request reports