Skip to content

Improve the performance bar

Quang-Minh Nguyen requested to merge qmnguyen0711/improve-performance-bar into master

What does this MR do?

The performance bar is helpful to detect the issues with replica/primary redirections in the recent rapid action &5590 (closed). However, it soon exposes some limitation:

  • The details are sorted by duration. It's impossible to sort them by the time order.
  • The user (me) has to scroll and count the number of occurrences of cached, queries in a transaction, replica/primary manually for each request.
  • The top bar is expanding, and does not fit into the screen anymore.

Therefore, In this MR, I would love to:

  • Add a top section inside the detailed page to display some summaries of the request. The summary is sent from the backend.
  • Allow the details to be sorted chronologically, or by duration order.
  • Remove redundant information from the top bar. Right now I just shorten some of them, but in the next PR, all of them will be moved into the detailed page

Screenshots (strongly suggested)

Top of the details page in the performance bar

Screen_Shot_2021-03-18_at_13.32.19

After sorting chronologically, an unexpected bug shows up clearly

Screen_Shot_2021-03-17_at_17.22.11

Before moving details into the detail page

Screen_Shot_2021-03-18_at_14.10.44

After moving details into the detail page, the top bar becomes more compact:

Screen_Shot_2021-03-18_at_13.32.58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Quang-Minh Nguyen

Merge request reports