Skip to content

Combine sidebar reference components

Tom Quirk requested to merge combine-sidebar-reference-components into master

What does this MR do?

First step towards #324610 (closed).

There is a UI pattern of Label: value <clipboard-button /> used in the sidebar, e.g. issue references, MR branch names, issue email address. We don't have a reusable component for this pattern.

This MR adds a copyable_field.vue component to address this, and uses it for the Issue Reference on Jira issues.

Future MRs (e.g. !56826 (merged)) will utilize the new component for other use cases.

This feature is currently behind the jira_issues_show_integration feature flag (disabled by default)

Screenshots (strongly suggested)

Screenshots demonstrate that there is no impact to the user.

Before After
Screen_Shot_2021-03-18_at_1.22.12_pm Screen_Shot_2021-03-18_at_1.16.32_pm
Screen_Shot_2021-03-18_at_1.22.17_pm Screen_Shot_2021-03-18_at_1.16.38_pm
Screen_Shot_2021-03-18_at_1.22.30_pm Screen_Shot_2021-03-18_at_1.17.08_pm
Screen_Shot_2021-03-18_at_1.22.35_pm Screen_Shot_2021-03-18_at_1.16.44_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports