Fix MR widget alignment
What does this MR do?
Adjust the left-padding for the MR widget reports children and sub-children to be properly aligned with their parent.
This fixes an issue that was pointed out in a comment of a related issue.
This also fixes an issue with the test history badge stretching to fill the height of the issue name.
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Merge request reports
Activity
added devopsverify frontend grouppipeline security sectionops typebug labels
- Resolved by Scott Hampton
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Michael Lunøe ( @mlunoe
) (UTC+2, 9 hours ahead of@shampton
)Mike Greiling ( @mikegreiling
) (UTC-5, 2 hours ahead of@shampton
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #283907 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 08e972e0 and bc18d559
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.04 MB 3.04 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for 08e972e0. So we have used data from: 0e8208cb.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖@shampton
👏 Praise: thank you for quickly putting this MR together!🙂 - Resolved by Pedro Moreira da Silva
@beckalippert
🎨 Style: From a quick look at the screenshot in the description of this MR, it looks like the sub-children are still not aligned to the text of the children, compared to the proposal :face_with_monocle:Because this change will also impact the security widget (and I think @rayana is quite busy at the moment), would mind reviewing this? If so, feel free to assign yourself as a reviewer.
@rayana FYI
🙏
mentioned in merge request gitlab-ui!2093 (merged)
requested review from @beckalippert
changed milestone to %13.11
- Resolved by Jose Ivan Vargas
@pburdette can you do the review for this?
assigned to @pburdette
requested review from @pburdette
unassigned @pburdette
@jivanvl can you do the maintainer review for this?
assigned to @jivanvl
requested review from @jivanvl
- Resolved by Jose Ivan Vargas
enabled an automatic merge when the pipeline for 8f02ba90 succeeds
- Resolved by Scott Hampton
enabled an automatic merge when the pipeline for 101f8984 succeeds
mentioned in commit a87fb437
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #291990 (closed)
added releasedcandidate label
mentioned in issue #330819 (closed)