Skip to content
Snippets Groups Projects

Fix MR widget alignment

Merged Scott Hampton requested to merge fix-mr-issues-list-padding into master
All threads resolved!

What does this MR do?

Adjust the left-padding for the MR widget reports children and sub-children to be properly aligned with their parent.

This fixes an issue that was pointed out in a comment of a related issue.

This also fixes an issue with the test history badge stretching to fill the height of the issue name.

Screenshots (strongly suggested)

Before After
Screen_Shot_2021-03-16_at_8.38.51_AM Screen_Shot_2021-03-18_at_8.18.40_AM
Screen_Shot_2021-03-22_at_9.00.00_AM Screen_Shot_2021-03-22_at_8.55.08_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Scott Hampton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    frontend Michael Lunøe (@mlunoe) (UTC+2, 9 hours ahead of @shampton) Mike Greiling (@mikegreiling) (UTC-5, 2 hours ahead of @shampton)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • mentioned in issue #283907 (closed)

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 08e972e0 and bc18d559

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.04 MB 3.04 MB - 0.0 %
    mainChunk 1.87 MB 1.87 MB - 0.0 %

    Note: We do not have exact data for 08e972e0. So we have used data from: 0e8208cb.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • @shampton 👏 Praise: thank you for quickly putting this MR together! 🙂

  • mentioned in merge request gitlab-ui!2093 (merged)

  • Scott Hampton changed the description

    changed the description

  • Scott Hampton added 1 commit

    added 1 commit

    Compare with previous version

  • requested review from @beckalippert

  • Scott Hampton added 1 commit

    added 1 commit

    • 44229bc8 - Fix test history badge alignment

    Compare with previous version

  • Scott Hampton added 1 commit

    added 1 commit

    • ac0b91eb - Fix test history badge alignment

    Compare with previous version

  • Scott Hampton changed the description

    changed the description

  • Becka Lippert approved this merge request

    approved this merge request

  • Scott Hampton marked this merge request as ready

    marked this merge request as ready

  • Scott Hampton changed the description

    changed the description

  • Scott Hampton changed milestone to %13.11

    changed milestone to %13.11

  • Scott Hampton resolved all threads

    resolved all threads

  • Scott Hampton requested review from @pburdette

    requested review from @pburdette

  • Scott Hampton added 1 commit

    added 1 commit

    • cd205130 - Fix test history badge alignment

    Compare with previous version

  • Payton Burdette approved this merge request

    approved this merge request

  • Author Maintainer

    @jivanvl can you do the maintainer review for this?

  • assigned to @jivanvl

  • Scott Hampton requested review from @jivanvl

    requested review from @jivanvl

  • added 1 commit

    • bc678148 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jose Ivan Vargas resolved all threads

    resolved all threads

  • Jose Ivan Vargas approved this merge request

    approved this merge request

  • This looks good to me!

  • Jose Ivan Vargas enabled an automatic merge when the pipeline for 8f02ba90 succeeds

    enabled an automatic merge when the pipeline for 8f02ba90 succeeds

  • Scott Hampton
  • Scott Hampton resolved all threads

    resolved all threads

  • Scott Hampton aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Scott Hampton added 1 commit

    added 1 commit

    • bc18d559 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Jose Ivan Vargas enabled an automatic merge when the pipeline for 101f8984 succeeds

    enabled an automatic merge when the pipeline for 101f8984 succeeds

  • mentioned in commit a87fb437

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #330819 (closed)

  • Please register or sign in to reply
    Loading