Skip to content

Move graphql timelogs to ce

Lee Tickett requested to merge move-graphql-timelogs-to-ce into master

What does this MR do?

Timelogs are part of CE, but the graphql code was accidently added to EE. This MR moves it to CE.

There have been some user reports of this issue:

Screenshots (strongly suggested)

Before

Pop a some time against an issue:

image

image

Then run the following graphql:

query {
  group(fullPath: "twitter") {
    id
    name
    timelogs(startDate: "2021-03-01", endDate: "2021-03-30") {
      nodes {
        timeSpent
        issue {
          id
        }
        note {
          body
        }
      }
    }
  }
}

Result:

{
    "data": {
        "group": {
            "id": "gid://gitlab/Group/27",
            "name": "Twitter",
            "timelogs": {
                "nodes": []
            }
        }
    }
}

After

{
    "data": {
        "group": {
            "id": "gid://gitlab/Group/27",
            "name": "Twitter",
            "timelogs": {
                "nodes": [
                    {
                        "timeSpent": 600,
                        "issue": {
                            "id": "gid://gitlab/Issue/141"
                        },
                        "note": {
                            "body": "Another note with some more time"
                        }
                    }
                ]
            }
        }
    }
}

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports