Skip to content

Hide rotation restriction when rotation length is hourly

Tristan Read requested to merge tr-on-call-schedule-hide-restriction into master

What does this MR do?

On call rotations can have a time restriction that limits them to certain hours in a day.

This restriction doesn't make sense for rotation of less than a day. So we hide that section of the form when the rotation length is 'hourly'.

issue: #262859 (closed)

discussion: #262859 (comment 500826685)

Follow-ups (Deferred because they will conflict with other in-flight MRs)

  • Refactor form to use new updateRotationForm method.
  • Refactor form specs to use trigger instead of $emit.

Testing notes

  • Feature flag :oncall_schedules_mvc
  • Requires a GitLab Premium license or higher

Screenshots (strongly suggested)

before after
Screenshot_2021-03-15_at_14.46.58 Screenshot_2021-03-15_at_14.46.24

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports