Rescue errors when emitting Snowplow events
What does this MR do?
When a Snowplow event is emitted (by calling Gitlab::Tracking.event
), we want to ensure that we do not raise any errors, even when the event is bad/invalid (eg. missing category
). We can do this by taking inspiration from the Snowplow API helper and rescuing errors that occur within Gitlab::Tracking.event
. A log message is also written to keep track of errors. Example of such an error affecting production: #238229 (closed).
!56267 (merged) removes the API helper in favour of calling Gitlab::Tracking.event
directly, so this MR is also in preparation for that.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because no user-facing changes.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alishan Ladhani