Remove runtime vue template from gitpod settings[RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
The use of vue templates defined in haml
is a bad practice. This removes one needless instance of this pattern from the gitpod integration settings within the admin dashboard.
There is no change to functionality, the vue template is merely converted into a native render function within pages/admin/application_settings/general/index.js
.
Screenshots (strongly suggested)
same before & after |
---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
related to: #321093 (closed)
Edited by Jose Ivan Vargas