Draft: Button migration
What does this MR do?
This MR does two great big regex replaces to get all the remaining HAML buttons migrated to GitLab UI.
find | replace |
---|---|
(^(?!.*gl-button).*class:.*)btn (.*$) |
$1gl-button btn $2 |
(^(?!.*gl-button).*)(\.btn[\.{]) |
$1.gl-button$2 |
btn-inverted |
btn-secondary (where appropriate) |
There were a couple of files that escaped the gaze of our regex queries, so I've manually updated those too. Because of that, I'm only 99% sure we've caught everything, but I'll take those odds.
Screenshots (strongly suggested)
We'll want to go through these as a team in
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Sam Beckham