Skip to content

Show loading spinner for security dashboard charts

What does this MR do?

On the project, group, and instance-level security dashboards, we show a sparkline chart and an accordion for the project security status:

ksnip_20210314-222028

While data is loading, the chart and accordion shows no 0 vulnerabilities, which is misleading until the data finally loads. This can be especially misleading if the data takes a long time to load, like it does for the gitlab-org group:

https://gitlab.com/groups/gitlab-org/-/security/dashboard

This MR fixes it by adding a loading spinner while the data is loading (note that there's also a full-page loading spinner that shows before the two panels are shown):

Before After
Peek_2021-03-14_22-23 Peek_2021-03-14_22-22

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #284471 (closed)

Edited by Daniel Tian

Merge request reports