Change all Project.for_group_and_its_subgroups to group.all_projects
What does this MR do?
This is mainly motivated by performance issues we were seeing with
WHERE ID IN(...) queries
https://gitlab.com/gitlab-com/gl-infra/production/-/issues/3894 .
Those were addressed by updating the #all_projects method to use
INNER JOIN instead
!56078 (merged) so it's
better if we move as much code to using #all_projects as possible . It
happens that #all_projects is actually less code to write in all these
places.
After removing all occurrences of Project.for_group_and_its_subgroups
it's now clear that the scope isn't even needed anymore as it was never
chained with anything else so we can remove it.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #324220 (closed)