Skip to content

Add plan limit for Terraform Module package file size

Matt Kasa requested to merge 321102-terraform-module-registry-iteration-1 into master

What does this MR do?

Adds a plan limit for Terraform Module package file size.

Terraform Module packages are being added as part of #321102 (closed) and this plan limit will need to exist for that feature.

Related to #321102 (closed)

Database

Migrations

Adds terraform_module_max_file_size column to the plan_limits table with a default value of 1073741824 (1GB).

Up

== 20210305145622 AddTerraformModuleMaxFileSizeToPlanLimits: migrating ========
-- add_column(:plan_limits, :terraform_module_max_file_size, :bigint, {:default=>1073741824, :null=>false})
   -> 0.0032s
== 20210305145622 AddTerraformModuleMaxFileSizeToPlanLimits: migrated (0.0033s)

Down

== 20210305145622 AddTerraformModuleMaxFileSizeToPlanLimits: reverting ========
-- remove_column(:plan_limits, :terraform_module_max_file_size, :bigint, {:default=>1073741824, :null=>false})
   -> 0.0032s
== 20210305145622 AddTerraformModuleMaxFileSizeToPlanLimits: reverted (0.0063s)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Matt Kasa

Merge request reports