Skip to content

Make keyboard shortcut help dynamic

Lukas 'ai-pi' Eipert requested to merge leipert-dynamic-kbd-help into master

What does this MR do?

This makes the keyboard shortcut styles dynamic, based on our keybindings definition. Also make sure that styles in typography (markdown) and keyboard shortcut help match. Now that the data is dynamic we can also add a search (which also solves the "toggle-focus" problem).

Screenshots (strongly suggested)

What Before After
Dark Mode Screenshot_2021-03-22_at_23.44.26 Screenshot_2021-03-22_at_23.43.33
Light Mode Screenshot_2021-03-22_at_23.44.39 Screenshot_2021-03-22_at_23.43.03
Search N/A shortcuts-after
Search (No results) N/A Screenshot_2021-03-22_at_23.42.58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas 'ai-pi' Eipert

Merge request reports