Skip to content

Update RuleForm inputs to use GlFormInput and GlFormGroup

What does this MR do?

This MR replaces the RuleForm's inputs with GlFormInput and GlFormGroup. Previously this was using the classes of these components but not actually using them, which made the view particularly convoluted and repetitive. Using them directly, retains the same style but also makes the view simpler and means this form will be kept up-to-date with future GitLab UI changes.

This does not change any of the visual aspects of the form.

This is a two-part refactor:

Step MR
Refactor the validation !56961 (merged)
Refactor to use GlFormInput/GlFormGroup 👉 You are here

Screenshots (strongly suggested)

Form With validation errors
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

  1. Open a project and go to project settings, then open the Merge request approvals section
  2. Check that adding and editing approval rules works as expected

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #323729 (closed)

Edited by Robert Hunt

Merge request reports