Remove bottom border from header
What does this MR do?
Removes the bottom border from our top nav, that was implemented as part of 3b3f755b. The original intent according to @dzaporozhets was due to a previous redesign:
It was probably times when sidebar was colorful and header was white. To separate header from content the border was introduced Since then we shifted the design around a few times so that this is not necessary anymore. Instead, it already creates problems on the light theme where there is another box-shadow, creating a 2px wide border.
In addition to that, it also creates a weird effect when you are scrolling over content and the light grey border becomes visible like this:
Screenshots (strongly suggested)
| Before | After |
|---|---|
|
 |
|
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team