Skip to content

Update Pages CI/CD template examples to default branch

Marcel Amirault requested to merge update-ci-template-default-branch-1 into master

What does this MR do?

We have a lot of template examples for various deployments with Pages. Many have associated projects at: https://gitlab.com/pages (I'll update these separately, when I get access to the top-level group. Edit: I now have access, so after this merges I'll update those templates to match)

As part of the linked issue, we should make sure they all point to $CI_DEFAULT_BRANCH and not a hardcoded default branch like master.

Changes:

  • Before:

    only:
      - master

    After:

    rules:
      - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
  • For templates that used except, we shouldn't jump straight to rules, see: !56301 (comment 526788078). So:

    Before:

    only:
      - master
    
    except:
      - master

    After:

    only:
      variables:
        - $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
    
    except:
      variables:
        - $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH

Related to #324131 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marcel Amirault

Merge request reports