Skip to content

Add reviewers detail to approve/unapprove MR emails

What does this MR do?

This MR adds reviewer information to approved_merge_request_email and unapproved_merge_request_email

Related to #300750 (closed)

Screenshots (strongly suggested)

Approved - HTML version

Screen_Shot_2021-03-11_at_12.37.57_pm

Approved - Text version

Screen_Shot_2021-03-11_at_12.37.47_pm

Unpproved - HTML version

Screen_Shot_2021-03-11_at_12.37.23_pm

Unpproved - Text version

Screen_Shot_2021-03-11_at_12.37.32_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300750 (closed)

Edited by Sincheol (David) Kim

Merge request reports