Skip to content

Add commit_email to Users API

Dan Jensen requested to merge 324105-add-commit-email-to-users-api into master

What does this MR do?

The User#commit_email attribute has as much importance as public_email (for example, it is also relevant to privacy), but is frequently overlooked. For example, the Users API does not support it, whereas it does support public_email. This adds support for the User#commit_email attribute to the Users API to make it equivalent to public_email. Update: Because commit_email is sensitive like email, it is treated the same way as email, meaning only visible to admins.

This also clarifies the documentation for creating users by removing public_email, which is not officially supported by that endpoint.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #324105 (closed)

Edited by Dan Jensen

Merge request reports