Skip user limit validation when saving cloud licenses
What does this MR do?
Related to #324090
As discussed in #324090, it was decided that the user limit validations on License should be avoided for Cloud Licenses. This will help to streamline the activation process, allowing the customer to activate a subscription (essentially saving the license to their instance) even if the subscription is for less than the purchased quantity. The overage will be reconciled at the first quarterly reconciliation. Beyond that, we will routinely be saving new licenses during cloud sync and these should be saved even if there is an overage.
This MR:
- Skips the
check_users_limit
validation in theLicense
model ifcloud?
is true. - Introduces the
License#cloud?
method to easily return a boolean for whether the license is a cloud license.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tyler Amos