Skip to content

Improve MR Retarget Chain to prefer usage of `MR::DeleteSourceBranchWorker`

Kamil Trzciński requested to merge improve-retarget-merge-requests into master

What does this MR do?

Related to:

This fixes the outstanding problems handling user choice of whether to delete or not source branch:

  1. If a MR has a remove source branch saved, even unchecking that on right hand of Merge button will still retarget the MR
  2. If a MR does not have a remove source branch saved, even checking that on right hand of Merge will not retarget the MR

This does not solve:

  1. Clicking Remove Source Branch after MR is merged calls DELETE /branches and thus does not trigger retarget

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon

Merge request reports