Improve MR Retarget Chain to prefer usage of `MR::DeleteSourceBranchWorker`
What does this MR do?
Related to:
This fixes the outstanding problems handling user choice of whether to delete or not source branch:
- If a MR has a
remove source branch
saved, even unchecking that on right hand ofMerge
button will still retarget the MR - If a MR does not have a
remove source branch
saved, even checking that on right hand ofMerge
will not retarget the MR
This does not solve:
- Clicking
Remove Source Branch
after MR is merged callsDELETE /branches
and thus does not trigger retarget
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon