Skip to content

Convert Commit dropdown to Vue

Doug Stull requested to merge 299346-convert-dropdown-on-commit-page-to-vue into master

What does this MR do?

  • Converts the commit options dropdown to Vue/pajamas.
  • Removes Browse files from becoming part of dropdown in mobile displays and leaves it as a button full-width.
  • Removes the dropdown section divider when not needed.

Test locally(GDK)

Go to any commit and observe the options dropdown. Fixes styling when user not logged in.

Screenshots (strongly suggested)

platform before after
desktop Screen_Shot_2021-03-15_at_3.30.50_PM Screen_Shot_2021-03-15_at_3.21.18_PM
mobile Screen_Shot_2021-03-15_at_3.31.16_PM Screen_Shot_2021-03-15_at_3.22.35_PM
desktop Screen_Shot_2021-03-15_at_3.32.00_PM Screen_Shot_2021-03-15_at_3.39.39_PM
mobile Screen_Shot_2021-03-15_at_3.32.21_PM Screen_Shot_2021-03-15_at_3.39.55_PM

When user not logged in(fixed divider showing)

before after
Screen_Shot_2021-03-15_at_4.17.22_PM Screen_Shot_2021-03-15_at_3.46.21_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #299346

Edited by Doug Stull

Merge request reports