Skip to content

Resolve "ee-specific-lines-check should take the old base one commit before the one we want"

Lin Jen-Shin requested to merge 5923-pass-old-base-one-commit-before into master

What does this MR do?

Make ee-specific-lines-check take the old base one commit before the one we want

Why was this MR needed?

This was explained in https://content.pivotal.io/blog/git-rebase-onto

Previously I was not passing old base as a merge-base because the result is the same. But if we want to pass a commit before it, then that's quite different and we need merge-base to find the old base we really want.

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

What are the relevant issue numbers?

Closes #5923 (closed)

Merge request reports