Skip to content

Add Jira Issue Note component

Tom Quirk requested to merge add-jira-note-component into master

What does this MR do?

Adds a new component, note.vue, for the purpose of rendering comments in Jira issues within GitLab.

This component is a barebones, readonly, gitlab-ui-powered version of noteable_note.vue. noteable_note.vue is tightly coupled to Vuex, an event hub, and jquery, and as such is not suitable for other use-cases such as this one.

I have tried to keep the component as "pure" as possible - my hope is that, at a certain point in the future, we can move this component to vue_shared. Then, we could build components that use this shared component internally (like design_note.vue, notes on commits/diffs, etc.).

There are no user-facing changes in this MR - rendering of comments is introduced in !56069 (merged) (iteration 2).

Iteration MR
1. Add note.vue component You are here 🚀
2. Render comments on Jira issues within GitLab !56069 (merged)

UX approval was given in !55814 (comment 523526607)

Related issue: #322638 (closed)

Screenshots (strongly suggested)

Again, no user-facing changes in this MR, but we can see the component in use in the iteration that follows (!56069 (merged)):

Large Small With long username
Screen_Shot_2021-03-05_at_3.30.49_pm Screen_Shot_2021-03-05_at_3.31.02_pm Screen_Shot_2021-03-05_at_3.31.37_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports