User mentions not working for usernames ending in `_`
What does this MR do?
In !45922 (merged) we were a little over ambitious in converting all escapable punctuation characters, including _ and *.
As a result, @user\_, which is a valid user format (so that the _ isn't considered an italics character), was no longer recognized as a valid user reference.
So now we're limiting ourselves to just the characters that trigger one of our special references: @ # ! $ & ~ % ^
Screenshots (strongly suggested)
Testing
You can test this by enabled in the feature flag honor_escaped_markdown. Then you enter the user name @mpeychet. It should autocomplete to @mpeychet\_. This should end up being a valid user reference.
However \@mpeychet\_ is NOT a valid reference, because the @ is escaped.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #323618 (closed) and #16827 (closed)