Skip to content

Break out Gitlab::Geo::LogCursor::Daemon

Ash McKenzie requested to merge 4957-projectsyncworker-should-skip-projects-that-have-a-broken-gitaly-shard-4 into master

What does this MR do?

This is an extension of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5537

This MR breaks out various event handling logic from Gitlab::Geo::LogCursor::Daemon into respective Gitlab::Geo::LogCursor::Events::<EventType>Event classes.

Gitlab::Geo::LogCursor::Events is now Gitlab::Geo::LogCursor::EventLogs (as that's what it concerns itself with) and has its class methods converted into instances methods to protect internal logic.

Are there points in the code the reviewer needs to double check?

Fairly straightforward refactor, mostly cut-n-pasting logic from Gitlab::Geo::LogCursor::Daemon into respective Gitlab::Geo::LogCursor::Events::<EventType>Event classes (and also extracting out test logic).

Why was this MR needed?

Gitlab::Geo::LogCursor::Daemon was responsible for multiple roles making it tricky to both test and parse.

Screenshots (if relevant)

N/A

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • [ ] API support added
  • Tests added for this feature/bug
  • Review
    • [ ] Has been reviewed by UX
    • [ ] Has been reviewed by Frontend
    • Has been reviewed by Backend
    • [ ] Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • [ ] Internationalization required/considered
  • [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #4957 (closed)

Edited by Nick Thomas

Merge request reports