Skip to content

Upgrade gitlab-styles to version 6.2.0

Mehmet Emin INAC requested to merge implement_final_let_it_be_cop into master

What does this MR do?

This MR upgrades to gitlab-styles 6.2.0.

New check rules

This upgrade enables the following cops:

  • Performance/OpenStruct - 16 offenses
    • Make sure this static analysis check rule is enabled for new usage
    • Current offenses are ignored but will be fixed as a separate iteration: #325744 (closed)
  • RSpec/EmptyLineAfterFinalLet - 1162 offenses
    • Make sure this static analysis check rule is enabled for new usage
    • Current offenses are ignored but will be fixed as a separate iteration: TODO
  • Once approved and merged by a maintainer, mention new rules again:
    • In the relevant Slack channels (e.g. #development, #backend, #frontend)
    • (Optional depending on the impact of the change) In the Engineering Week in Review

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports