Skip to content

Refactor merge request view specs

Doug Stull requested to merge 296640-refactor-view-test into master

What does this MR do?

  • while working on !51400 (merged) I noticed a lot of factories being created in these view specs that didn't need to be and other improvements that could be made.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296640

Edited by Alex Kalderimis

Merge request reports