Move the isNumeric util to the shared number_utils.js
What does this MR do?
The isNumeric
function was being used in both the custom compliance frameworks and audit events files. To remove duplication, this is now moved into number_utils.js
and the files now reference this instead.
Screenshots (strongly suggested)
No visual changes, purely a code refactor
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this is a code refactor and has no impact on the view shown to the user.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
The spec tests should cover that this method works as expected. If you wish to test the actual view itself, please see the testing instructions in !55096 (merged).
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #323326 (closed)
Edited by Robert Hunt