Skip to content

DRY up "#{Gitlab.config.gitlab.host}:#{Gitlab.config.gitlab.port}" [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Eric Engestrom requested to merge 1ace/gitlab:dry-up-gitlab-host into master

What does this MR do?

As suggested by @tkuah, this MR replaces the multiple occurrences of "#{Gitlab.config.gitlab.host}:#{Gitlab.config.gitlab.port}" with a simple Gitlab.host_port, following the naming convention already used (eg. Gitlab.config.registry.host_port).

Closes #322521 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports