Skip to content

Include suite errors in test summary

Erick Bajao requested to merge eb-test-summary-suite-error into master

What does this MR do?

backend work for #263457 (closed)

This covers the test summary page. frontend already has existing code to handle the suite_error so we just need to expose the attribute in the API response in /pipelines/:id/tests/summary.json.

This adds suite_error in the Ci::BuildReportResult#data JSON payload upon creation.

Please note that it's possible that multiple builds in a group such as rspec 1/2 and rspec 2/2 may have their own suite errors. But for now, given we only expose a single error on the UI, we only return the first error we find from the group of build report results.

Screenshots (strongly suggested)

Here's a screenshot of the UI already at work once we expose the suite_error. Screen_Shot_2021-03-05_at_8.30.41_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Bajao

Merge request reports