Skip to content

Re-organise `gfm_autocomplete_spec.rb` spec

Coung Ngo requested to merge cngo-refactor-gfm_autocomplete_specrb into master

What does this MR do?

This MR organises gfm_autocomplete_spec.rb by:

  • creating a new xss checks section
  • tidying the labels section by extracting created labels to let_it_be
  • deletes some unnecessary tests

The first half of the file tests when the tribute_autocomplete feature flag is off, and the second half of the file tests when it is on.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports