Skip to content

Add client_id to Application Context

Alex Buijs requested to merge add-client-id-application-context-metadata into master

What does this MR do?

This MR adds the client_id to the context. It's value is one of the following, in order of precedence:

  • user/user.id
  • runner/runner.id
  • ip/request.ip

Tasks:

In addition, it removes wrapping every spec in a separate context, thereby avoiding unnecessary context initializations. Wrapping can still be enabled by using the context_aware flag.

Issue: gitlab-com/gl-infra/scalability#126 (closed) and #321831 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Buijs

Merge request reports