Skip to content

Mark required fields with `required` and `aria-required` attributes

Peter Hegman requested to merge 294436-create-project-required-fields into master

📖 What does this MR do?

Related to #294436 (closed)

Improves a11y and how a screen reader announces the create project pages. Adds required and aria-required attributes to required fields on "Create blank project" and "Import an exported GitLab project" pages

💻 Local testing

  1. Navigate to projects/new#blank_project or /import/gitlab_project/new?namespace_id=1&name=&path=
  2. Turn on VoiceOver (⌘ + F5)
  3. Use Tab to navigate through the fields

📹 Videos

Safari w/ VoiceOver

View Before After
Create project Screen_Recording_2021-03-04_at_9.51.49_AM Screen_Recording_2021-03-04_at_9.45.28_AM
Import GitLab project Screen_Recording_2021-03-04_at_9.53.02_AM Screen_Recording_2021-03-04_at_9.48.02_AM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports