Skip to content

Geo repository verification: ignore repos/wikis needing resync

Brett Walker requested to merge bw-verification-resync-fix into master

What does this MR do?

When querying for project registries to verify, ignore if the repository or wiki needs to be resynced.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Registry entries were being unnecessarily pulled when the repository should not be verified because the synchronization failed. In addition, if there were many sync failures (over 1000), then we could get in a state where these were the only records being pulled and therefore valid records are never handled.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [-] Documentation created/updated
  • [-] API support added
  • Tests added for this feature/bug
  • Review
    • [-] Has been reviewed by UX
    • [-] Has been reviewed by Frontend
    • Has been reviewed by Backend
    • [-] Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • [-] Internationalization required/considered
  • [-] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#5879 (closed)

Edited by Brett Walker

Merge request reports